[oneMKL] Rename oneMKL Interface project #596
Conversation
| @@ -11,8 +11,8 @@ BLAS-like Extensions | |||
| .. container:: | |||
|
|
|||
|
|
|||
| oneAPI Math Kernel Library DPC++ provides additional routines to | |||
| extend the functionality of the BLAS routines. These include routines | |||
| oneAPI Math Library DPC++ provides additional routines to extend | |||
There was a problem hiding this comment.
Since we have |onemath_full_name|m should we replace here: |onemath_full_name| (oneMath) ? and maybe look for it elsewhere ?
There was a problem hiding this comment.
I updated them in 19c21e4 and, as far as I can tell, there aren't other occurrences of the full name
|
Hi @rscohn2, these changes are failing |
Add it here: https://github.com/uxlfoundation/oneAPI-spec/blob/main/.reuse/dep5 |
- Move source/elements/oneMKL to source/elements/oneMath - Rename files using "mkl" or "onemkl" to "onemath" - Rename occurrences of "oneMKL" and "onemkl" to "oneMath" and "onemath" respectively Signed-off-by: nscipione <[email protected]>
- Rename the namespace oneapi::mkl to oneapi::math and references to the folder oneapi/mkl to oneapi/math Signed-off-by: nscipione <[email protected]>
- Rename remaining occurrences of "mkl" to "onemath" Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Fix table format Signed-off-by: nscipione <[email protected]>
Replace wrong usage of "onemath" as namespace in favor of the correct "math" Signed-off-by: nscipione <[email protected]>
Set full name to "oneAPI Math Library" and update reference to it Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Rename macros for domain and for version Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
s-Nick
force-pushed
the
onemkl_to_onemath
branch
from
1e339a0
to
c3301d5
Compare
There was a problem hiding this comment.
The changes look good to me!
For future reference I am also adding the link to the main RFC: oneapi-src/oneMKL#564
Signed-off-by: nscipione <[email protected]>
| To help the calling application, all oneMath routines with at least one USM pointer argument also take an optional reference to a list of *input events*, of type ``std::vector<sycl::event>``, and have a return value of type ``sycl::event`` representing computation completion:: | ||
|
|
||
| sycl::event math::domain::routine(..., std::vector<sycl::event> &in_events = {}); | ||
|
|
There was a problem hiding this comment.
we need to add const to the front of these types: const std::vector<sycl::event>&
There was a problem hiding this comment.
Agree, that looks like a small fix that can be done as part of this PR
There was a problem hiding this comment.
yeah, I hesitated to toss it into here, but is small enough to just make the change ...
|
@sknepper I see you have approved the renaming of the implementation but not this specification PR. Just pinging you here in case one of the domain owners of lapack want to approve this PR before November 29. |
This PR address RFC #580.
It performs all the changes to namespace, name and file name requested in the issue.
EDIT:
For completeness, I attach a zip of the html version with changes
oneMath_html.zip